feat(RHIDP-872): Enable RHDH nodejs metrics #75
Conversation
| monitoring_step: 15 | ||
| {%- endmacro %} | ||
|
|
||
| {% for query in [ |
There was a problem hiding this comment.
Here it might be easier to read just a multiple calls to that macro instead of a loop with these ifs. And maybe learn rhdh_nodejs_lst to accept value_list instead of just value:
rhdh_nodejs_lst('catalog_processors_duration_seconds_sum', 'result', ['ok', 'failed'])
rhdh_nodejs_lst('catalog_processors_duration_seconds_count', 'result', ['ok', 'failed'])
rhdh_nodejs_lst('catalog_processing_duration_seconds_sum', 'result', ['unchanged'])
rhdh_nodejs_lst('catalog_processing_duration_seconds_count', 'result', ['unchanged'])
rhdh_nodejs_lst('nodejs_gc_duration_seconds_sum', 'kind', ['minor', 'major', 'incremental'])
rhdh_nodejs_lst('nodejs_gc_duration_seconds_count', 'kind', ['minor', 'major', 'incremental'])
rhdh_nodejs_lst('catalog_entities_count', 'kind', ['location', 'user', 'group'])
There was a problem hiding this comment.
Thinking about it more, are these metrics important for us? Or do we want to just collect averages?
catalog_processors_duration_seconds_sum{result="ok"} / catalog_processors_duration_seconds_count{result="ok"}
And maybe just number of failed ones?
rate(catalog_processors_duration_seconds_count{result="failed"}[5m])
I mean - instead of collecting all/lots of the individual metrics that are there, just collect these we actually care about?
There was a problem hiding this comment.
Hello @jhutar , thanks for the comments, in the latest commit I have rewritten metric collection in more readable way, as you have suggested and also added metrics for gathering rates and averages instead of just raw data.
jhutar
changed the title
yogananth-subramanian
force-pushed
the
rhdh-metrics
branch
3 times, most recently
from
ec67382 to
89ccd7e
Compare
Enable collecting RHDH nodejs prometheus metrics. The environement variable RHDH_METRIC is set to true to enable collecting the metrics.
yogananth-subramanian
force-pushed
the
rhdh-metrics
branch
from
89ccd7e to
9f994f5
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhutar, yogananth-subramanian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you! |
openshift-merge-bot
bot
merged commit d630f48
into
redhat-performance:main
Enable collecting RHDH nodejs prometheus metrics.
The environement variable RHDH_METRIC is set to true to enable collecting the metrics.